Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes WebSockets from the network layer #3039

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

cschuchardt88
Copy link
Member

Closes #3038

Change Log

  • Removes WebSocket from Core network functions
  • Sets NodeCapabilityType to Obsolete for WsServer. (So older nodes can still serialize and deserialize without disconnect)

@cschuchardt88 cschuchardt88 changed the title Removes WebSockets from the network procotol Removes WebSockets from the network layer Dec 28, 2023
@Jim8y
Copy link
Contributor

Jim8y commented Dec 29, 2023

Update config.json as well please.

Jim8y
Jim8y previously approved these changes Dec 29, 2023
roman-khimov
roman-khimov previously approved these changes Dec 29, 2023
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the warnings from ut

@cschuchardt88
Copy link
Member Author

That is a new feature. For this reason:
Sets NodeCapabilityType to Obsolete for WsServer. (So older nodes can still serialize and deserialize without disconnect)

@cschuchardt88 cschuchardt88 dismissed stale reviews from roman-khimov and Jim8y via 214ae38 January 2, 2024 03:45
@cschuchardt88 cschuchardt88 requested a review from shargon January 2, 2024 03:46
@shargon shargon merged commit 9f50e37 into neo-project:master Jan 2, 2024
2 checks passed
@shargon shargon deleted the remove-websockets branch January 2, 2024 09:18
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 10, 2024
* master:
  Fixed asp.net core project (neo-project#3067)
  Updated BLS12_381 (neo-project#3074)
  avoid nonsense exception messages. (neo-project#3063)
  Removed `MyGet` (neo-project#3071)
  Updated unit-test (neo-project#3073)
  add hash verification for OnImport (neo-project#3070)
  Make public ReadUserInput (neo-project#3068)
  Removed asp.net core (neo-project#3065)
  Enforce Line Endings in `.editorconfig` (neo-project#3060)
  Remove some warnings (neo-project#3057)
  Fixed workflow  timeout-minutes (neo-project#3048)
  Fix: specify the error message (neo-project#3030)
  Removes `WebSocket`s from the network layer (neo-project#3039)
  set timeout for tests (neo-project#3046)
  Fix: Editconfig (neo-project#3023)
  Set project as nullable (neo-project#3042)
  Fix: fix equal (neo-project#3028)

# Conflicts:
#	src/Neo.CLI/CLI/MainService.cs
#	src/Neo.CLI/Settings.cs
#	src/Neo/ProtocolSettings.cs
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket in NeoSystem doesn't work
4 participants